Bug 2034484: feat: updated library-go#972
Bug 2034484: feat: updated library-go#972openshift-merge-robot merged 3 commits intoopenshift:masterfrom
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
| } | ||
|
|
||
| func (optr *Operator) syncValidatingWebhook() error { | ||
| expectedGeneration := resourcemerge.ExpectedValidatingWebhooksConfiguration(mapiwebhooks.NewValidatingWebhookConfiguration().Name, optr.generations) |
There was a problem hiding this comment.
I'm not 100% sure on the ramifications of this change here, would love some input and context. The expectedGeneration was removed from this methods signature per this PR. Any potential problems that we might need to consider here?
openshift-ci
Bot
added
the
needs-rebase
eggfoobar
force-pushed
the
library_go_bump
branch
from
d3580a4 to
f6ddec6
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
/test unit |
Signed-off-by: ehila <ehila@redhat.com>
updated leader election to delegate to library-go for configs leader election is now topology aware for its configs Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
library_go_bump
branch
from
f6ddec6 to
9a0bc4f
Compare
|
/retest-required |
|
/retitle Bug 2034484: feat: updated library-go |
openshift-ci
Bot
changed the title
openshift-ci
Bot
added
the
bugzilla/severity-high
|
@eggfoobar: This pull request references Bugzilla bug 2034484, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (jhou@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
bugzilla/valid-bug
|
/retest-required |
| "strconv" | ||
|
|
||
| osconfigv1 "github.com/openshift/api/config/v1" | ||
|
|
There was a problem hiding this comment.
This new line seems to be randomly added, can we remove it please?
There was a problem hiding this comment.
Sure thing, updated
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Signed-off-by: ehila <ehila@redhat.com>
eggfoobar
force-pushed
the
library_go_bump
branch
from
9a0bc4f to
f1655ab
Compare
|
/retest-required |
|
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
@eggfoobar: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2034484 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
Bumping the library-go dependency to latest, this should take advantage of leader election changes for SNO clusters proposed in this library-go PR and performance improvements in this PR.
Changes:
Signed-off-by: ehila ehila@redhat.com